fixed clippy errors

.gitignore

@@ -1,3 +1,4 @@
 /target
 /result
 /uploads
+*.swp

src/auth.rs

@@ -24,7 +24,7 @@ pub fn hash_password(password: &str) -> Result<String, APIError> {
         .hash_password(password.as_bytes(), &salt)
         .map_err(|e| e.to_string())
         .map(|ph| ph.to_string())
-        .map_err(|e| APIError::Internal(e))
+        .map_err(APIError::Internal)
 }
 
 pub fn verify_password(hash: &str, password: &str) -> bool {
@@ -70,12 +70,12 @@ pub fn verify_jwt(headers: HeaderMap) -> Result<Claims, APIError> {
     verify_jwt_string(&token.to_string())
 }
 
-pub fn verify_jwt_string(token: &String) -> Result<Claims, APIError> {
+pub fn verify_jwt_string(token: &str) -> Result<Claims, APIError> {
     let secret =
         std::env::var("FRANGIPANE_JWT_SECRET").unwrap_or_else(|_| DEFAULT_SECRET_KEY.to_string());
 
     decode::<Claims>(
-        token.as_str(),
+        token,
         &DecodingKey::from_secret(secret.as_ref()),
         &Validation::default(),
     )

src/realtime.rs

@@ -43,6 +43,12 @@ impl RealtimeMessages {
     }
 }
 
+impl Default for RealtimeMessages {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl RealTimeVoices {
     pub fn new() -> Self {
         Self {
@@ -63,3 +69,9 @@ impl RealTimeVoices {
         self.rooms.retain(|_, sender| sender.receiver_count() > 0);
     }
 }
+
+impl Default for RealTimeVoices {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/routes/messages.rs

@@ -171,14 +171,14 @@ async fn create_message(
     .bind(room_id)
     .bind(&payload.message_type)
     .bind(&payload.content)
-    .bind(&uuid)
+    .bind(uuid)
     .fetch_one(&db)
     .await?;
 
     let sender_name = username_from_uuid(&db, claims.sub).await?;
 
     let message = Message {
-        uuid: uuid,
+        uuid,
         room_uuid,
         sender: sender_name,
         sender_uuid: claims.sub,
@@ -263,12 +263,12 @@ async fn handle_message_socket(
             // Receive broadcast messages and send to client (any room)
             msg = receiver.recv() => {
                 if let Ok(msg) = msg {
-                    if let Ok(json) = serde_json::to_string(&msg) {
-                        if socket.send(WsMessage::Text(json.into())).await.is_err() {
+                    if let Ok(json) = serde_json::to_string(&msg)
+                        && socket.send(WsMessage::Text(json.into())).await.is_err()
+                    {
                         tracing::error!("Failed to send message to {who}, closing connection");
                         break;
                     }
-                    }
                 } else {
                     break;
                 }
@@ -287,20 +287,24 @@ async fn handle_message_socket(
             // Get incoming messages from client
             client_msg = socket.recv() => {
                 if let Some(Ok(msg)) = client_msg {
-                    match msg {
-                        // WsMessage::Pong(_) => {
-                        //     tracing::debug!("Received Pong from {who}");
+                    // match msg {
+                    //     // WsMessage::Pong(_) => {
+                    //     //     tracing::debug!("Received Pong from {who}");
+                    //     // }
+                    //     // WsMessage::Ping(_) => {
+                    //     //     tracing::info!("Received Ping from client");
+                    //     // }
+                    //     // WsMessage::Text(_) => {}
+                    //     WsMessage::Close(_) => {
+                    //         tracing::debug!("Client disconnected");
+                    //         break;
                     //     }
-                        // WsMessage::Ping(_) => {
-                        //     tracing::info!("Received Ping from client");
+                    //     _ => {}
                     // }
-                        // WsMessage::Text(_) => {}
-                        WsMessage::Close(_) => {
+                    if let WsMessage::Close(_) = msg {
                         tracing::debug!("Client disconnected");
                         break;
                     }
-                        _ => {}
-                    }
                 } else {
                     tracing::debug!("Client {who} abruptly disconnected");
                     break;

src/routes/rooms.rs

@@ -95,9 +95,6 @@ async fn list_rooms(
     Extension(db): Extension<PgPool>,
 ) -> Result<Json<Vec<Room>>, APIError> {
     let claims = verify_jwt(headers)?;
-    if claims.sub != claims.sub {
-        return Err(APIError::InvalidToken);
-    }
 
     let user_id = user_id_from_uuid(&db, claims.sub).await?;
 
@@ -142,7 +139,8 @@ async fn create_room(
 
     {
         let room_name_length = payload.name.len();
-        if room_name_length > MAX_ROOM_NAME_LENGTH || room_name_length < 1 {
+        // if room_name_length > MAX_ROOM_NAME_LENGTH || room_name_length < 1 {
+        if !(1..=MAX_ROOM_NAME_LENGTH).contains(&room_name_length) {
             return Err(APIError::RoomNameLength);
         }
     }

src/routes/users.rs

@@ -161,15 +161,15 @@ pub async fn register_user(
     .execute(&db)
     .await
     .map_err(|e| {
-        if let Some(db_err) = e.as_database_error() {
-            if db_err.code().map(|c| c == "23505").unwrap_or(false) {
+        if let Some(db_err) = e.as_database_error()
+            && db_err.code().map(|c| c == "23505").unwrap_or(false)
+        {
             match db_err.constraint() {
                 Some("user__username_key") => return APIError::UsernameTaken,
                 Some("user__email_key") => return APIError::EmailTaken,
                 _ => return APIError::Internal("".to_string()), // TODO: handle this case
             }
         }
-        }
         APIError::DatabaseError(e)
     })?;
 
@@ -226,15 +226,15 @@ pub async fn update_user(
         .execute(&mut *tx)
         .await
         .map_err(|e| {
-            if let Some(db_err) = e.as_database_error() {
-                if db_err.code().map(|c| c == "23505").unwrap_or(false) {
+            if let Some(db_err) = e.as_database_error()
+                && db_err.code().map(|c| c == "23505").unwrap_or(false)
+            {
                 match db_err.constraint() {
                     Some("user__username_key") => return APIError::UsernameTaken,
                     Some("user__email_key") => return APIError::EmailTaken,
                     _ => return APIError::Internal("".to_string()), // TODO: handle this case
                 }
             }
-            }
             APIError::DatabaseError(e)
         })?;
 

src/routes/voice.rs

@@ -81,25 +81,25 @@ async fn handle_voice_socket(
         select! {
             // Receive audio from other users and send to client
             voice_packet = rx.recv() => {
-                if let Ok((speaker_uuid, audio_data)) = voice_packet {
-                    if speaker_uuid != my_uuid {
+                if let Ok((speaker_uuid, audio_data)) = voice_packet
+                    && speaker_uuid != my_uuid
+                {
                     let mut msg = BytesMut::with_capacity(16 + audio_data.len());
                     msg.put(speaker_uuid.as_bytes().as_slice());
                     msg.put(audio_data);
 
-                        if socket.send(Message::Binary(msg.freeze().into())).await.is_err() {
+                    if socket.send(Message::Binary(msg.freeze())).await.is_err() {
                         break;
                     }
                 }
             }
-            }
 
             // Receive audio from alient and broadcast to room
             client_msg = socket.recv() => {
                 if let Some(Ok(msg)) = client_msg {
                     match msg {
                         Message::Binary(data) => {
-                            let _ = tx.send((my_uuid, Bytes::from(data)));
+                            let _ = tx.send((my_uuid, data));
                         }
                         Message::Close(_) => {
                             tracing::debug!("Voice client {} disconnected", who);